Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a before and after loc comparsion to picking up dropship equipment. #5856

Closed
wants to merge 1 commit into from

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Mar 1, 2024

About the pull request

Should fix #5848

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Should no longer be possible to pick up the same dropship equiment with 2 different powerloaders
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 1, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a similar check to /obj/vehicle/multitile/proc/uninstall_hardpoint()?
That seems to be the only other 'picking something up with a powerloader' proc that could end up having the same problem.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 10, 2024
@Drulikar Drulikar marked this pull request as draft March 11, 2024 21:22
@TheGamerdk TheGamerdk closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two Powerloaders can pick up the same object.Breaks an attachment point when placed
2 participants